Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Addressing issues found trying to run the dependency parser on MIOpen:
Of course,
git diffalso returns all files modified in every other project's commits. These are filtered out as early as possible.This solution searches for
rocm-librariesin theparsingstep, and if found extracts the project name and stores it inenhanced_dependency_mapping.json. Leading folders are truncated from each file path, up to and including the project name. This allows_is_project_fileto remain unchanged.The
selectionstep then retrieves the project name from the json if it is defined, and truncates the project folder from thegit diffoutput so the filenames exactly match the json entries.Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
Successfully runs on rocm-libraries MIOpen PRs and produces a list of tests. I haven't verified the results yet.
This version is not applicable to CI since it operates on a per-executable level and MIOpen CI uses the single gtest binary. I'll be working towards that in future PRs over the next few weeks.
I don't know if clang-format applies to scripts. If so, could someone show me how to run it in CK?