Add Radeon AI PRO R9700 to gpu-nfd-default-rule files#416
Open
Add Radeon AI PRO R9700 to gpu-nfd-default-rule files#416
Conversation
Author
Now merge is blocked by spelling check on documentation? I didn't touch documentation. How can I fix and move on? |
Member
We just pushed some fixes to the CI test, could you pls rebase your PR ? |
The pci id of new released Radeon AI PRO R9700 is 1002:7551 7551 is missing in gpu-nfd-default-rule files, so nfd cannot find AMD GPU on a node with Radeon AI PRO R9700.
Author
It's rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The pci id of new released Radeon AI PRO R9700 is 1002:7551 7551 is missing in gpu-nfd-default-rule files, so nfd cannot find AMD GPU on a node with Radeon AI PRO R9700.
Technical Details
Modified 2 rule files
hack/k8s-patch/template-patch/gpu-nfd-default-rule.yaml
helm-charts-k8s/templates/gpu-nfd-default-rule.yaml
Add a section of id 7551
Test Plan
Tested with a real k8s cluster with Radeon AI PRO R9700
Test Result
It's able to recognize the AMD GPU with nfd and gpu device plugin is created on these nodes