[Feature] Add minimal AlmaLinux support (#53)#439
Open
gigabyte132 wants to merge 1 commit intoROCm:mainfrom
Open
[Feature] Add minimal AlmaLinux support (#53)#439gigabyte132 wants to merge 1 commit intoROCm:mainfrom
gigabyte132 wants to merge 1 commit intoROCm:mainfrom
Conversation
Signed-off-by: Raulian-Ionut Chiorescu <raulian-ionut.chiorescu@cern.ch>
3193edc to
b82e56a
Compare
Member
|
Hi @gigabyte132 thanks for raising this PR, would you mind:
we would evaluate your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds minimal AlmaLinux support, addressing errors like the one described here (#53):
err: OS: almalinux 8.10 (cerulean leopard) not supported. Should be one of [red hat redhat ubuntu coreos rhel]
Technical Details
This PR adds an
almaCMNameMappermethod, allowing the GPU operator to run on AlmaLinux nodes.This PR does not add full support for AlmaLinux (i.e. providing the template dockerfiles), it functions in the 2 cases where we use the inbox AMD drivers or have external builds of the driver image.
Test Plan
We have tested this on AlmaLinux 9.5 as well as AlmaLinux 10.1 successfuly with an external driver container build (30.20) as well as the inbox drivers. Please do let me know if you would like me to add additional tests.
Test Result
The GPU operator exposes the AMD GPUs as expected on nodes running AlmaLinux 9.5 as well as AlmaLinux 10.1.
Submission Checklist