Skip to content

[Feature] Add kernel-accessible ImageBatchVarShapeWrapper#154

Draft
zacharyvincze wants to merge 21 commits into
ROCm:developfrom
zacharyvincze:zv/feature/image-wrapper-varshape
Draft

[Feature] Add kernel-accessible ImageBatchVarShapeWrapper#154
zacharyvincze wants to merge 21 commits into
ROCm:developfrom
zacharyvincze:zv/feature/image-wrapper-varshape

Conversation

@zacharyvincze
Copy link
Copy Markdown
Contributor

PR Description

  • Code Changes
    • Adds the required kernel-accessible wrappers for the ImageBatchVarShape container.
    • Renames ImageWrapper to TensorWrapper for clarity purposes. TensorWrapper should be used to wrap Tensor, while ImageBatchVarShapeWrapper wraps its respective ImageBatchVarShape.
    • Reworks BorderWrapper and InterpolationWrapper so that they can be composed with either TensorWrapper or ImageBatchVarShapeWrapper. Reduces potential code duplication.
  • Tests
    • Adds unit tests for all newly added types. Ensures ImageBatchVarShape can perform a round-trip copy from the GPU to the host while indexing properly. Also tests composability with the BorderWrapper implementation.

Notes

@zacharyvincze zacharyvincze self-assigned this May 29, 2026
@zacharyvincze zacharyvincze changed the title Zv/feature/image wrapper varshape [Feature] Add kernel-accessible ImageBatchVarShapeWrapper May 29, 2026
@zacharyvincze zacharyvincze added enhancement New feature or request ci:precheckin labels May 29, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.61151% with 80 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/detail/var_shape_descriptor_table.cpp 81.32% 8 Missing and 9 partials ⚠️
src/core/image_batch_var_shape.cpp 85.47% 10 Missing and 7 partials ⚠️
src/op_adv_cvt_color.cpp 63.64% 16 Missing ⚠️
src/core/image.cpp 85.88% 7 Missing and 5 partials ⚠️
include/core/image_batch_var_shape.hpp 16.67% 5 Missing ⚠️
include/core/image_data.hpp 55.56% 3 Missing and 1 partial ⚠️
include/core/wrappers/interpolation_wrapper.hpp 69.23% 4 Missing ⚠️
include/core/image.hpp 57.14% 3 Missing ⚠️
include/core/image_format.hpp 80.00% 0 Missing and 1 partial ⚠️
include/core/wrappers/tensor_wrapper.hpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #154      +/-   ##
===========================================
+ Coverage    78.13%   78.97%   +0.84%     
===========================================
  Files           79       90      +11     
  Lines         3347     3762     +415     
  Branches       733      790      +57     
===========================================
+ Hits          2615     2971     +356     
- Misses         369      405      +36     
- Partials       363      386      +23     
Files with missing lines Coverage Δ
include/core/detail/var_shape_descriptor_table.hpp 100.00% <100.00%> (ø)
include/core/image_batch_data.hpp 100.00% <100.00%> (ø)
include/core/image_storage.hpp 100.00% <100.00%> (ø)
include/core/wrappers/border_wrapper.hpp 74.14% <100.00%> (+1.92%) ⬆️
include/kernels/host/convert_to_host.hpp 100.00% <ø> (ø)
include/kernels/host/reformat_host.hpp 100.00% <100.00%> (ø)
src/core/image_batch_data.cpp 100.00% <100.00%> (ø)
src/core/image_data.cpp 100.00% <100.00%> (ø)
src/op_bilateral_filter.cpp 77.00% <100.00%> (-0.23%) ⬇️
src/op_bnd_box.cpp 78.62% <100.00%> (ø)
... and 25 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:precheckin enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants