Fix CMake return & update CMake messages #381
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove argument to
return()in CMake.returndoes not take error code and will fail with CMP0140 enabled, it also does not terminate the file correctly under the old policy. Ref https://cmake.org/cmake/help/latest/command/return.htmlChange "not building examples" message from STATUS to WARNING and make the preceding
find_packagequiet for better visibility.Technical Details
Standardize CMake warning and status messages:
WARNINGfor missing dependencies & unsupported ASICs for better visibilitySTATUSfor unsupported platforms (CUDA/Windows/Linux)Test Plan
rocJPEG is not properly skipped with
return(1). With this PR it is properly skipped.Test Result
Added/Updated documentation?
Included Visual Studio files?
Submission Checklist