WIP: refactor topk extract_digit_flip_xaxis #4214
Closed
paulklie wants to merge 36 commits intoROCm:developfrom
Closed
WIP: refactor topk extract_digit_flip_xaxis #4214paulklie wants to merge 36 commits intoROCm:developfrom
paulklie wants to merge 36 commits intoROCm:developfrom
Conversation
wip2 wip wip wip wip fix cleanups year linted fix feedback improved zeroing function
…m:amd/libraries/rocm-libraries into users/paulklie/topk_twiddlein
…e/topk_twiddlein' # Conflicts: # projects/rocprim/rocprim/include/rocprim/device/detail/device_topk_air.hpp # projects/rocprim/test/rocprim/test_device_topk.cpp # projects/rocprim/test/rocprim/test_utils_data_generation.hpp
assistant-librarian
Bot
added
the
external contribution
Contributor
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
Contributor
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR build up on #3646, and should be merged afterwards.
Motivation
#3646 adds an implementation for topk. The
extract_digit_flip_xaxisfunction might be reused in other similar algorithms (such as segmented topk). Thus we decided to move its logic to projects/rocprim/rocprim/include/rocprim/type_traits.hpp.Technical Details
Test Plan
Run topk tests and benchmarks.
Test Result
Tests passed. No benchmark regressions.
Submission Checklist