Conversation
After loading, null it out so we don't keep serializing it and it won't be the target of a reference in the future.
Add back the AbstractTemplate.zoneId field so XStream can reference it
Every other part of token dragging measures against the anchor, and this discrepency meant the FoW checks were not checking the correct position.
This lets rendering still be done smoothly, but validation is done "cell by cell" even when the preference is disabled.
StampTool doesn't have the same issue as PointerTool since it doesn't validation drags, but we might as well keep the structure as similar as possible.
…-PointerTool 1.16 - Fix bad FoW check in PointerTool
The ratio (and therefore second dimension) depend on the size, so should be set after the grid's size is known.
…dimensions Fix hex grid dimensions when reading from GridDto
…tractDrawingLikeTool This fixes tooltips for drawing, expose and topology tools which are instance-based. This is because the `Tool` class sets the tooltip in the constructor using `getTooltip()`, which returns `null` for instance-based classes since their fields have not been initialized yet. This is a bad pattern, but we got away with when keys were all hardcoded in the methods themselves.
1.16 - Make tooltips show again for drawing tools, fog of war tools, and topology tools
1.16 - fix map dragging for drawing tools and expose tools
cwisniew
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the 1.16 fixes into develop
This change is