Merged
Conversation
added 2 commits
March 24, 2023 15:56
see the comments on this MR st-one-io#41
db8f38b to
6c64d0f
Compare
Collaborator
Author
|
A PR for this branch was also created in the upstream project, and outlines a few concerns with the changes to the payload and the tests st-one-io#41 |
Collaborator
Author
|
The CI job is failing, but so does |
|
Are you concerned about this error @ferm10n? If not, I think it's fine to approve. |
Collaborator
Author
This was a failing test on |
joshpruett
approved these changes
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context
st-one-io#40