Skip to content

fix: Exception thrown when heapify empty queue (#32) #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RamType0 merged 2 commits into from
Dec 26, 2025
+7 −5
Merged

fix: Exception thrown when heapify empty queue (#32) #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1210901
fix: Exception thrown when heapify empty queue (#32)
RamType0 Dec 26, 2025
5d7c7b7
fix: Missing space after 'if' keyword
RamType0 Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions Runtime/UnsafeMinPriorityQueue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,7 @@ public void EnqueueRange(ReadOnlySpan<T> elements)
{
nodes.AddRangeNoResize(ptr, elements.Length);
}
if (Count > 1)
{
Heapify();
}
Heapify();
}
else
{
Expand Down Expand Up @@ -180,7 +177,7 @@ private void RemoveRootNode()
/// Gets the index of an element's parent.
/// </summary>
[return: AssumeRange(0, (int.MaxValue - 1) >> Log2Arity)]
private static int GetParentIndex(int index) => (index - 1) >> Log2Arity;
private static int GetParentIndex([AssumeRange(1, int.MaxValue)] int index) => (index - 1) >> Log2Arity;

/// <summary>
/// Gets the index of the first child of an element.
Expand All @@ -192,6 +189,11 @@ private void RemoveRootNode()
/// </summary>
internal void Heapify()
{
if (nodes.Length <= 1)
{
return;
}

// Leaves of the tree are in fact 1-element heaps, for which there
// is no need to correct them. The heap property needs to be restored
// only for higher nodes, starting from the first node that has children.
Expand Down
Loading