Bump sass-loader from 13.3.3 to 16.0.7#1466
Conversation
Bumps [sass-loader](https://github.com/webpack/sass-loader) from 13.3.3 to 16.0.7. - [Release notes](https://github.com/webpack/sass-loader/releases) - [Changelog](https://github.com/webpack/sass-loader/blob/main/CHANGELOG.md) - [Commits](webpack/sass-loader@v13.3.3...v16.0.7) --- updated-dependencies: - dependency-name: sass-loader dependency-version: 16.0.7 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Stale comment
No blocking issues found in this dependency bump.
Security
- I could not find any published GitHub/Snyk advisories for
sass-loader13.3.3or16.0.7, and the upstreamwebpack/sass-loaderrepo currently shows no published vulnerability alerts.- The lockfile change is narrow: it updates
sass-loaderitself and keeps the same direct dependency footprint (neo-asyncremains the only listed package dependency for the loader). I did not find any new supply-chain concern introduced by this PR.- I also did not find any resolved security issue that would make this an urgent patch-level security upgrade.
Safety Of Merging
- This is a semver-major update, so the relevant upstream breaking changes are the ones introduced in
14.x-16.x:14.0.0raised the minimum supported Node.js version to18.12.0and removedfiberssupport.15.0.0preferssass-embeddedoversasswhen both are present.16.0.0switched the default Sass JS API to the modern API.- In this repository, the only
sass-loaderusage is inwebpack.config.js, and it already setsapi: "modern"plussassOptions.loadPaths, so the biggest16.xbehavior change is effectively already opted into here.- This repo depends on
sass, notsass-embedded, so the15.xdefault preference change should not affect current builds.- The one practical caveat is Node version: the repo itself is pinned to Node
20.20.0in.tool-versions, and the GitHub Actions workflow also uses Node20, so CI should be fine. But anyone still building locally on Node16will need to upgrade before usingsass-loader16.x.Local Test Results
yarn install --immutable: passed (with existing peer-dependency warnings, but no install failure from this bump)yarn lint: passedyarn build: passed; webpack compiled successfullyCI=true yarn run test --coverage --maxWorkers=4 --workerThreads=true --reporters=default --reporters=jest-junit --reporters=jest-github-actions-reporter: passed (92suites,820tests)yarn start: passed; webpack dev server compiled successfullycurl -I http://localhost:3011/web-component.html: returned200 OK- Cypress e2e could not be completed in this environment because the Cypress binary was not preinstalled and downloading it from
download.cypress.iofailed with an SSL/network error. That looks like an environment/network restriction, not a regression caused by this PR.Recommendation
Merge with caution.
The upgrade looks safe for this repository as currently configured, and I did not find a security reason to hold it. The only thing I would verify outside CI is that any local/devcontainer/preview environments still in use are on Node
18.12+(ideally Node20, matching the repo config and workflow).Sent by Cursor Automation: Editor-UI - Tests Dependabot PRs
There was a problem hiding this comment.
No blocking findings.
Security
- I did not find any published GHSA/CVE/npm advisory affecting
sass-loader@16.0.7; upstream16.0.7is a patch release whose only documented change is widening the optional@rspack/corepeer for v2 support. - The lockfile diff does not add new transitive runtime dependencies beyond the
sass-loadertarball update itself; it still depends onneo-async, withsass,sass-embedded,node-sass, andwebpackremaining peer dependencies. - Dependabot flagged an upstream
preparescript change, but the published package does not introducepreinstall/install/postinstallhooks. For a normal registry dependency, that does not create a new install-time execution path in this repo.
Safety of merging
- The meaningful breaking changes between
13.3.3and16.xare:14.0.0requires Node>=18.12.0and removesfiberssupport.15.0.0preferssass-embeddedoversasswhensass-embeddedis installed.16.0.0defaults to the modern Sass JS API.
- This repository already lines up with those changes:
.tool-versionsand.github/workflows/ci-cd.ymlare on Node20.sass-embeddedis not installed here, so the loader continues to usesass.webpack.config.jsalready setsapi: "modern", and the currentsassOptions.loadPaths/sourceMapconfiguration built successfully unchanged.
- I did not find repo code that appears coupled to the removed
fiberspath or to legacy Sass API-only options.
Local verification
yarn install --immutable: passed (existing peer-dependency warnings only)yarn lint: passedCI=true yarn test --coverage --maxWorkers=4 --workerThreads=true --reporters=default --reporters=jest-junit --reporters=jest-github-actions-reporter: passed (92suites,820tests)yarn build: passed- Local Cypress was not runnable on this agent: the Cypress package is present, but the desktop binary is not cached and
download.cypress.iowas unreachable from the agent (SSL_ERROR_SYSCALL) when I tried to install it.
Current PR checks
- GitHub Actions
lint: passing - GitHub Actions
test: passing - GitHub Actions
deploy-branch / build-deploy: passing - GitHub Actions
test-cypress: still in progress at review time
Recommendation
Merge with caution: I do not see a security or code-level blocker, but because this is a semver-major build-tool upgrade and local Cypress could not be executed on this agent, I would wait for the PR’s test-cypress job to finish green before merging. If that check passes, this looks safe to merge.
Sent by Cursor Automation: Editor-UI - Tests Dependabot PRs


Bumps sass-loader from 13.3.3 to 16.0.7.
Release notes
Sourced from sass-loader's releases.
... (truncated)
Changelog
Sourced from sass-loader's changelog.
... (truncated)
Commits
694c8d9chore(release): 16.0.7147d6abci: lint fix (#1294)24d12ecfix: update peer dependency for@rspack/corev2 (#1291)068201fdocs: fix link (#1287)57c9282chore(release): 16.0.6fbc1af9perf: cache fs calls for modern API (#1284)900a5f8chore: rewrite link to correct location (#1282)4d54d53chore: restore to old contente9dab32chore: revise readme information (#1280)1acdbd0chore: remove some redundant stuff (#1279)Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)