Use public url instead of s3 bucket#154
Merged
Merged
Conversation
This is for the development environment, so the webpack component can snarf anything from the main react UI app.
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
…berryPiFoundation/carrot-cake into use-public-url-instead-of-s3-bucket
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
raspberrypiherokubot
temporarily deployed
to
editor-ui-pi-use-public-j7avrf
loiswells97
approved these changes
Aug 3, 2022
Contributor
loiswells97
left a comment
loiswells97
left a comment
There was a problem hiding this comment.
Looks okay to me I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
PUBLIC_URLenv var to set URLs for the various bundles, shims,replacing REACT_APP_S3_BUCKETto allow assets to be served from sub directories in our S3 bucket.Blocked by #152REACT_APP_S3_BUCKETwithPUBLIC_URLeverywherebundle.jstoweb-component.jsindex.htmlasweb-component.html, and inject the bundle correctly into the body.build/web-component.html.The web component works, served straight from S3, picking up the asset paths correctly:
https://python-editor-dist-test.s3.eu-west-2.amazonaws.com/previews/use-public-url-instead-of-s3-bucket/web-component.html
However, the editor itself does not, because it makes the assumption it is being served form the root directory. I think that is too big to cover off in this PR, and maybe we should address it in a different way.
https://python-editor-dist-test.s3.eu-west-2.amazonaws.com/previews/use-public-url-instead-of-s3-bucket/index.html