Add a simple Procfile to serve static assets#155
Merged
Conversation
This then builds both the web component and the app itself.
loiswells97
approved these changes
Aug 3, 2022
Contributor
loiswells97
left a comment
There was a problem hiding this comment.
Looks okay I think 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heroku-postbuildscript inpackage.jsonwhich builds both the app and the web component. This takes precedence overbuildin the Heroku build process. This has a special env var ofPUBLIC_URLset to an empty string so the webcomponent builds properly..dockerignoreto make the docker build context smaller for faster local container rebuildsapp.jsonjust to make the Heroku deployment a bit more in-keeping with other apps.So this means that the review app is now served from https://editor-ui-pi-use-webric-wzk77h.herokuapp.com/ with a basic Ruby webserver, and then the webcomponent is at https://editor-ui-pi-use-webric-wzk77h.herokuapp.com/web-component.html 🎉
The main editor showing the sense hat working:
And the web-component:
Not sure this is great for production use, but it'll do.