feat(tests): add continuity tests for Synchronous mode#337
Open
mariborges22 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the 'sharpness' logic has a threshold at 16 (around smooth = 0.03125) where it switches from the tanh formula to a linear clamp. I was curious if this transition was perfectly smooth, so I wrote a test to compare the driver's output against a pure math simulator that doesn't use the clamp.
Everything is working as expected with no jumps in sensitivity, so I'm submitting this as a safety net for future changes.
What's inside:
ThresholdTests.cs
: The new test file.
UnclampedSynchronousSimulator
: A simple class to check the "true" math against the driver's optimized version.
Verified everything with and without the threshold to ensure the tests are actually catching differences.