Upgrade CI actions to latest major versions (Node.js 24)#2951
Conversation
GitHub Actions emits a deprecation warning when actions run on Node.js 20: "conda-incubator/setup-miniconda@v3 and julia-actions/install-juliaup@v2 are running on Node.js 20 and may not work as expected." Both actions have released newer major versions that move to Node.js 24: - conda-incubator/setup-miniconda v4 (Node.js 24) - julia-actions/install-juliaup v3 (Node.js 24) Upgrade all three workflow files (CI.yml, conda_build.yml, docs.yml) to remove these warnings and ensure continued compatibility as GitHub eventually retires Node.js 20 runners. Agent-Logs-Url: https://github.com/ReactionMechanismGenerator/RMG-Py/sessions/89dd52b8-94be-44c3-b6b7-8031ca29802e Co-authored-by: rwest <93807+rwest@users.noreply.github.com>
|
@copilot please look for other actions that can/should be upgraded, and do so - but be careful for breaking changes to the APIs because some upgrades are not drop-in replacements (please check) |
Also upgrade the following actions across all workflow files, checking
each for breaking changes and adapting the call sites where needed:
- docker/setup-qemu-action v3 → v4 (Node.js 24, no API changes)
- docker/setup-buildx-action v3 → v4 (Node.js 24, removes deprecated
inputs/outputs that we don't use)
- docker/login-action v3 → v4 (Node.js 24, no API changes)
- docker/build-push-action v6 → v7 (Node.js 24, removes DOCKER_BUILD_*
env vars we don't use)
- actions/upload-artifact v4 → v7 (Node.js 24, adds direct-upload
feature; no interface changes affecting our usage)
- actions/download-artifact v4 → v8 (v5 breaking change only affects
by-ID downloads; we download by name so it is safe)
- actions/github-script v8 → v9 (breaking change is require('@actions/
github') no longer works; we only use the injected github.rest client
and Node built-in require('fs'), both of which still work)
- thollander/actions-comment-pull-request v2 → v3 (breaking parameter
renames: filePath→file-path, pr_number→pr-number; updated in
annotate.yml accordingly)
Agent-Logs-Url: https://github.com/ReactionMechanismGenerator/RMG-Py/sessions/a5d5cf7e-139d-41e9-9e56-8a312fbeff41
Co-authored-by: rwest <93807+rwest@users.noreply.github.com>
Done in commit 3ae660b. Audited all actions across all workflow files and upgraded everything that had a newer major version available: Drop-in upgrades (no API changes for our usage):
Upgrade with call-site fixes (
Already at latest major version (no change needed):
|
JacksonBurns
left a comment
There was a problem hiding this comment.
Assuming all of the checks pass, this looks fine!
Motivation or Problem
GitHub Actions emits this deprecation warning in our CI logs:
As GitHub phases out Node.js 20 runners these actions could stop working. A full audit of all workflow files found additional outdated actions.
Description of Changes
Upgraded all outdated actions to their latest major versions (Node.js 24) across all workflow files:
CI.yml,conda_build.yml,docs.yml:conda-incubator/setup-miniconda@v3→v4CI.yml:julia-actions/install-juliaup@v2→v3docker/setup-qemu-action@v3→v4docker/setup-buildx-action@v3→v4docker/login-action@v3→v4docker/build-push-action@v6→v7actions/upload-artifact@v4→v7actions/download-artifact@v4→v8annotate.yml:actions/github-script@v8→v9thollander/actions-comment-pull-request@v2→v3(breaking parameter renames:filePath→file-path,pr_number→pr-number— updated in call site)Testing
All upgrades were checked for breaking changes against our actual usage. Most are drop-in replacements. The one call-site change required is the parameter rename for
thollander/actions-comment-pull-requestv3. CI will confirm they work correctly on the updated versions.Reviewer Tips
Check that CI passes with the new action versions. The only logic change is the parameter rename in
annotate.ymlforthollander/actions-comment-pull-request.