4.x: Detect un-awaited CompletionStageDisposables during tests#8093
4.x: Detect un-awaited CompletionStageDisposables during tests#8093akarnokd merged 2 commits intoReactiveX:4.xfrom
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.601 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.601 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (73.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8093 +/- ##
============================================
- Coverage 98.94% 98.90% -0.05%
- Complexity 6863 6867 +4
============================================
Files 767 767
Lines 48557 48586 +29
Branches 6506 6508 +2
============================================
+ Hits 48047 48052 +5
- Misses 388 397 +9
- Partials 122 137 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds a tracking mechanism to track
CompositeStageDisposables which are neverawait()'d orignore()'d orclose()'d.Mainly test time verification.
The trouble is that if they escape the executorservice scope, it can interrupt the unit test unexpectedly and result in failed tests due to operator bugs.
The error stacktrace will point at the test and where the CSD was allocated in the code.