fix: Deploy files with no extensions, fixes using qcoro with artifactory#12
Open
BatteredBunny wants to merge 1 commit intoRedFox20:masterfrom
Open
fix: Deploy files with no extensions, fixes using qcoro with artifactory#12BatteredBunny wants to merge 1 commit intoRedFox20:masterfrom
BatteredBunny wants to merge 1 commit intoRedFox20:masterfrom
Conversation
RedFox20
reviewed
Mar 2, 2026
| includes_root = package_full_path + '/include' | ||
| # TODO: should we include .cpp files for easier debugging? | ||
| includes_filter = ['.h','.hpp','.hxx','.hh','.c','.cpp','.cxx'] | ||
| includes_filter = ['.h','.hpp','.hxx','.hh','.c','.cpp','.cxx', ''] |
Owner
There was a problem hiding this comment.
This is really dangerous though. It will potentially break a lot of other packages. How could we prevent potentially random files from being added?
Contributor
Author
There was a problem hiding this comment.
Thats true, but i dont really understand why there would be random files in the include folder in the first place
Contributor
Author
There was a problem hiding this comment.
Especially random extensionless files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently files with no extensions get filtered out. This makes papa create a broken artifactory cache for qcoro.
QCoro headers are included like this:
#include <QCoro/QCoroTask>They are expressed via an extensionless file in the include folder, e.g include/qcoro6/qcoro/QCoroTimer containing
#include "qcorotimer.h"(Same pattern as in Qt)