Skip to content

Conversation

@stefanatwork
Copy link
Collaborator

No description provided.

svenwoop
svenwoop previously approved these changes Jan 12, 2026
Copy link
Collaborator

@svenwoop svenwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@christophriesinger
Copy link

Just for clarity, -march=skx and -march=skylake-avx512 are synonymous in Clang.

The -mprefer-vector-width=256 is redundant if -march=skylake-avx512 as can be seen here.

My question: Should we keep this limitation as spr, gnr, and other targets don't use TuningPrefer256Bit?
This limitation is only relevant for the auto-vectorizer. Is there significant Embree functionality not implemented by intrinsics and thus vectorized by the auto-vectorizer?

@svenwoop
Copy link
Collaborator

Good catch, @stefanatwork the prefer the -march=skx already includes the prefer256.

Embree does not rely on the auto vectorizer, thus there is no performance relevant part that should be affected by that perfer256 flag. If it gets removed you essentially make Embree regress (as just one 512bit instruction already causes issues on SKX) on SKX, with no gains on newer architectures.

@stefanatwork stefanatwork requested a review from svenwoop January 14, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants