Enable validating inputs without throwing exceptions #1566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henriquemoody
force-pushed
the
core/result-query
branch
from
c41503d to
03adbf7
Compare
henriquemoody
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1566 +/- ##
============================================
+ Coverage 97.43% 97.49% +0.06%
- Complexity 950 977 +27
============================================
Files 204 205 +1
Lines 2144 2199 +55
============================================
+ Hits 2089 2144 +55
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
henriquemoody
force-pushed
the
core/result-query
branch
2 times, most recently
from
7b3f724 to
b7c8fa5
Compare
alganet
previously approved these changes
Dec 22, 2025
Currently, the only way to handle when a validation fails is by `assert()`, which either throws an exception or doesn't. That means that every time a user wants to handle the results, they must use try-catch blocks, which may add some overhead. This commit introduces the `ResultQuery` class that wraps a `Result` object, providing an alternative to exception-based validation. This allows users to handle results directly without try-catch blocks. I’m taking a risky move here using the old method `validate()`, but I can’t think of a better name for this method.
henriquemoody
force-pushed
the
core/result-query
branch
from
b7c8fa5 to
16c2a75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only way to handle when a validation fails is by
assert(), which either throws an exception or doesn't. That means that every time a user wants to handle the results, they must use try-catch blocks, which may add some overhead.This commit introduces the
ResultQueryclass that wraps aResultobject, providing an alternative to exception-based validation. This allows users to handle results directly without try-catch blocks.I’m taking a risky move here using the old method
validate(), but I can’t think of a better name for this method.