fixes #105 Sideloaded resources don't get passed parent resources context#124
Open
rhec wants to merge 1 commit intoRestPack:masterfrom
Open
fixes #105 Sideloaded resources don't get passed parent resources context#124rhec wants to merge 1 commit intoRestPack:masterfrom
rhec wants to merge 1 commit intoRestPack:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my application I have some resources I'd like to side load, but they require some additional context to serialize properly. Pushing down the root context to sideloaded resources as described in #105 works for me, and that's what this PR does. Ideally though I think the context should be namespaced somehow so you can apply the root context to the root serializer, and specific sideloaded resource contexts to their respective serializers. What do you think?