Add swiftinterface API diff tracking for RevenueCatUI by facumenzella · Pull Request #6450 · RevenueCat/purchases-ios

facumenzella · 2026-03-12T13:08:34Z

Summary

Ports CircleCI API-diff changes to dynamic config in `.circleci/default_config.yml`
Splits API diff coverage into parallel `check-api-changes-revenuecat` and `check-api-changes-revenuecatui` jobs, and updates the requested-jobs allowlist for both names
Adds the initial `RevenueCatUI` `.swiftinterface` baseline files across all platforms
Extracts shared API diff logic into `fastlane/api_diff_helper.rb` (used by both `generate_swiftinterface` and `check_api_changes` lanes)
Keeps the `SubscriptionPeriod` Codable fix, with an explicit `CodingKeys` + `init(from:)` / `encode(to:)` implementation

Notes

`check_api_changes` uses plain `diff -u` to compare `.swiftinterface` files — any textual change (additive or breaking) will fail CI. To update baselines when changes are intentional: run `bundle exec fastlane ios generate_swiftinterface`, then copy the files from `/tmp/pr-swiftinterface/` into the `api/` directory.
The `generate_swiftinterface` CircleCI pipeline now updates both `RevenueCat` and `RevenueCatUI` baselines.

Test plan

`bundle exec fastlane ios generate_swiftinterface`
`bundle exec fastlane ios check_api_changes`
`REQUESTED_JOBS='check-api-changes-revenuecat check-api-changes-revenuecatui' node .circleci/generate-requested-jobs-config.js`

RevenueCat-Danger-Bot · 2026-03-12T15:46:41Z

	2 Warnings
⚠️	Size check is being bypassed due to the presence of the label "danger-bypass-size-limit"
⚠️	Size increase: 295.47 KB

Generated by 🚫 Danger

- Remove hardcoded `= "RevenueCat"` defaults from swiftinterface_pattern_for_sdk and find_swiftinterface_file — callers always pass module_name explicitly - Remove error_callback from sh call so sh raises on non-zero exit, making the rescue block actually reachable for breaking API change detection Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…king

Replace branch-specific `purchases_ios_pr6450_fix` with the canonical `purchases_ios` derived from the repo directory name on main. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…king

Using public-api-diff only caught breaking changes, not additions. This meant a new API added in PR 1 (no baseline update required) could be silently broken in PR 2 — the tool would compare against the old baseline that never contained the new API and report no issue. Restoring FileUtils.identical? + diff -u ensures any divergence from the committed baseline fails CI and forces an explicit baseline update. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 505ea10. Configure here.}

The committed baselines were generated locally with different build settings (missing -package-name, different declaration ordering) than what CI produces. Since check_api_changes now uses diff -u, the baselines must exactly match CI output. Downloaded from CircleCI jobs 541296 (RevenueCat) and 541284 (RevenueCatUI). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ajpallares

I have some more comments. Mostly about some seemingly unrelated diffs in this PR.

Also, the PR description should be updated and simplified I believe

ajpallares · 2026-04-22T16:06:44Z

Why are these files changing in this PR? There shouldn't be changes in the interfaces

ajpallares · 2026-04-22T16:07:06Z

This diff shouldn't be in this PR I believe?

These changes are required. When building RevenueCatUI with BUILD_LIBRARY_FOR_DISTRIBUTION=YES, the compiler performs stricter validation of its dependencies' interfaces. The synthesized Codable conformance on the class declaration produces different (and stricter) swiftinterface output than an explicit extension conformance, which caused build failures. Moving the conformance to an explicit extension with CodingKeys, init(from:), and encode(to:) resolves this.

Tried different things, and this was the only thing that worked

…l-public-api-diff steps Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…king

emerge-tools · 2026-04-23T10:30:38Z

📸 Snapshot Test

264 unchanged

Name	Added	Removed	Modified	Renamed	Unchanged	Errored	Approval
RevenueCat com.revenuecat.PaywallsTester	0	0	0	0	264	0	N/A

🛸 Powered by Emerge Tools

…king

ajpallares

It's great to have this! Just one suggestion of splitting this into 2 PRs, but I don't have a strong opinion, so I'm approving

ajpallares · 2026-04-23T17:13:09Z

+
+            Dir.chdir("..") do
+              sh("xcodebuild", "clean", "build",
+                 "-workspace", ".",


I suspect -workspace . was added to make RevenueCatUI resolve RevenueCat through the SPM graph?

Could this be the reason why we're seeing all the revenuecat-api-*.swiftinterface files change in this PR?

If so, for better traceability, this should probably be split into two PRs. WDYT @facumenzella? Not a blocker, but seems like it's better for traceability

facumenzella requested a review from a team as a code owner March 12, 2026 13:08

facumenzella added the pr:other label Mar 12, 2026

cursor Bot reviewed Mar 12, 2026

View reviewed changes

Comment thread fastlane/Fastfile

facumenzella added the danger-bypass-size-limit Apply this label to bypass Dangerbot's size limit. label Mar 12, 2026

Add RevenueCatUI API diff coverage

d38c553

facumenzella force-pushed the facundo/add-revenuecatui-swiftinterface-tracking branch from ccd7927 to d38c553 Compare April 21, 2026 09:15

facumenzella requested a review from a team as a code owner April 21, 2026 09:15

cursor Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread Sources/Purchasing/StoreKitAbstractions/SubscriptionPeriod.swift Outdated

Address bugbot follow-ups

d99d20c

cursor Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread api/revenuecatui-api-ios-simulator.swiftinterface Outdated

ajpallares reviewed Apr 21, 2026

View reviewed changes

Comment thread fastlane/api_diff_helper.rb Outdated

Comment thread fastlane/api_diff_helper.rb

Comment thread fastlane/api_diff_helper.rb Outdated

Comment thread fastlane/api_diff_helper.rb

facumenzella and others added 2 commits April 21, 2026 15:10

Merge branch 'main' into facundo/add-revenuecatui-swiftinterface-trac…

92a3add

…king

cursor Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread api/revenuecatui-api-ios.swiftinterface Outdated

Fix package name in RevenueCatUI swiftinterface baselines

b03cef3

Replace branch-specific `purchases_ios_pr6450_fix` with the canonical `purchases_ios` derived from the repo directory name on main. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

facumenzella requested a review from ajpallares April 21, 2026 13:39

cursor Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread api/revenuecatui-api-tvos.swiftinterface

facumenzella added 2 commits April 21, 2026 20:57

Merge branch 'main' into facundo/add-revenuecatui-swiftinterface-trac…

a9978ce

…king

Merge branch 'main' into facundo/add-revenuecatui-swiftinterface-trac…

5a73d32

…king

facumenzella enabled auto-merge (squash) April 22, 2026 09:33

cursor Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread .circleci/default_config.yml Outdated

ajpallares reviewed Apr 22, 2026

View reviewed changes

facumenzella and others added 2 commits April 22, 2026 18:19

Address review nits: remove misleading desc wording and unused instal…

88500eb

…l-public-api-diff steps Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Merge branch 'main' into facundo/add-revenuecatui-swiftinterface-trac…

19bc709

…king

Merge branch 'main' into facundo/add-revenuecatui-swiftinterface-trac…

dc8264b

…king

ajpallares approved these changes Apr 23, 2026

View reviewed changes

facumenzella merged commit 4c0672c into main Apr 23, 2026
16 of 18 checks passed

facumenzella deleted the facundo/add-revenuecatui-swiftinterface-tracking branch April 23, 2026 17:16

Conversation

facumenzella commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes

Test plan

Uh oh!

Uh oh!

RevenueCat-Danger-Bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ajpallares left a comment

Choose a reason for hiding this comment

Uh oh!

ajpallares Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

ajpallares Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

facumenzella Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

facumenzella Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emerge-tools Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📸 Snapshot Test

264 unchanged

Uh oh!

ajpallares left a comment

Choose a reason for hiding this comment

Uh oh!

ajpallares Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

facumenzella commented Mar 12, 2026 •

edited

Loading

RevenueCat-Danger-Bot commented Mar 12, 2026 •

edited

Loading

emerge-tools Bot commented Apr 23, 2026 •

edited

Loading