Add automated GitHub releases for purchases-ios-admob#6537
Merged
Conversation
polmiro
commented
Mar 31, 2026
vegaro
reviewed
Apr 1, 2026
polmiro
force-pushed
the
admob-github-releases
branch
from
f21440e to
92a497c
Compare
polmiro
force-pushed
the
admob-github-releases
branch
2 times, most recently
from
a5899a6 to
f0022d8
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
ajpallares
reviewed
Apr 3, 2026
Member
ajpallares
left a comment
ajpallares
left a comment
There was a problem hiding this comment.
Looking good! But I have two main comments:
- A proposal about not excluding PRs with the
pr:admoblabel from purchases-ios' Changelog - A fix to correctly link to PRs in purchases-ios from the CHANGELOG in purchases-ios-admob
polmiro
force-pushed
the
admob-github-releases
branch
from
89d7021 to
74f7721
Compare
ajpallares
approved these changes
Apr 17, 2026
Member
ajpallares
left a comment
ajpallares
left a comment
There was a problem hiding this comment.
Great job! Thanks!
I think the PR description is stale though. It would be good to update it.
Member
Author
|
@RCGitBot please review |
📸 Snapshot Test327 unchanged
🛸 Powered by Emerge Tools |
Add a new `admob_github_release` Fastlane lane that generates a changelog filtered by the `pr:admob` label and creates a GitHub release on the purchases-ios-admob repository. Wire it into the CI release workflow as a new `make-admob-release` job that runs after `deploy-to-purchases-ios-admob`.
…ls API - Point fastlane-plugin-revenuecat_internal to main (branch merged) - Rename filter_label to filter_labels (array) for admob changelog - Exclude pr:admob PRs from purchases-ios changelog via exclude_labels
The main SDK release should not be gated on the admob adapter deployment.
Fetch the tag's commit SHA from purchases-ios-admob via the GitHub API and pass it as commitish, instead of using the local purchases-ios HEAD which doesn't exist in that repo.
This reverts commit 2edfdcc.
Co-authored-by: Pol Miro <polmiro@users.noreply.github.com>
Removes the bump lane exclusion so admob-labeled PRs remain visible in purchases-ios release notes for traceability.
Passes purchases-ios as the PR reference source so changelog links in purchases-ios-admob releases resolve to the correct repository.
polmiro
force-pushed
the
admob-github-releases
branch
from
00f0f6c to
16d8b1f
Compare
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
admob_github_releaseFastlane lane that generates a changelog filtered bypr:admoblabel and creates a GitHub release onpurchases-ios-admobmake-admob-releaseCI job that runs afterdeploy-to-purchases-ios-admobin the release workflowtarget_commitishfrompurchases-ios-admobvia the GitHub API, since the CI job runs inpurchases-ioswhere HEAD is a different repo's commitcross_repo_pr_reference: 'RevenueCat/purchases-ios'so PR links in the admob release notes resolve back to this repomake-releaseno longer requiresdeploy-to-purchases-ios-admob, so the main SDK release isn't gated on the adapter deploymentHow it works
deploy-to-purchases-ios-admobpushes the adapter code and tag topurchases-ios-admobmake-admob-releasethen runs, generating a changelog from PRs tagged withpr:admobpurchases-ios-admobviaGET /repos/RevenueCat/purchases-ios-admob/git/ref/tags/{version}and passes it ascommitishto the releasepr:admoblabel, the release body defaults to "Release X.Y.Z"pr:admobPRs still appear in the mainpurchases-ioschangelog as well (no exclusion is applied)Dependencies
commitishparam tocreate_github_release) — mergedTest plan
make-admob-releasejob in CI to validate the lane workspurchases-ios-admobwith the correcttarget_commitishbundle updateto refreshGemfile.lockand commit.Note
Medium Risk
Updates the release pipeline and GitHub release automation, which could affect tag deployments and release publishing if the new job/lane misbehaves. No runtime SDK code changes.
Overview
Adds an automated post-deploy step to publish a GitHub release for
purchases-ios-admobon release tags.CircleCI now runs a new
make-admob-releasejob afterdeploy-to-purchases-ios-admob, and the Fastlaneadmob_github_releaselane generates a changelog filtered topr:admobPRs and creates the release inpurchases-ios-admobusing the tag’s resolved commit SHA (via the GitHubgit/refAPI) so the release targets the correct commit.Reviewed by Cursor Bugbot for commit 16d8b1f. Bugbot is set up for automated code reviews on this repo. Configure here.