Refuse to receive worker messages once dead.

[pkaminski]

Addresses https://reviewableio.sentry.io/issues/7326447743. It appears that it's possible for a worker to send the crash message (which clears out the deferreds table), but then try to send more responses afterwards.

---

This change is 

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where a worker, after sending a crash message and clearing its deferred tasks, could still attempt to send subsequent responses, leading to errors. The changes introduce a mechanism to ensure that once a worker is considered 'dead', it will no longer process any incoming messages, thereby preventing these post-crash communication problems and improving system stability.

Highlights

• Worker Message Handling: Implemented a safeguard to prevent a worker from processing messages once it has been marked as 'dead', addressing a potential bug where messages could still be received after a crash.

Changelog

• package.json
  • Incremented the package version from 7.8.3 to 7.8.4.
• src/Bridge.js
  • Added a conditional check at the beginning of the _receive method to immediately return if the _dead flag is set, preventing further message processing by a dead bridge.

Activity

• Addressed a Sentry issue (https://reviewableio.sentry.io/issues/7326447743) by implementing a fix to prevent dead workers from receiving messages.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a race condition where messages from a web worker could be processed after the worker has been marked as dead. The change introduces a guard clause in the _receive method to ignore any incoming messages if the worker is considered dead. This effectively prevents errors from processing further responses from a crashed worker. The implementation is correct and directly solves the reported issue.