Skip to content

Fix source name persistence (#391)#501

Draft
RhysSullivan wants to merge 1 commit intomainfrom
fix/391-source-name-persistence
Draft

Fix source name persistence (#391)#501
RhysSullivan wants to merge 1 commit intomainfrom
fix/391-source-name-persistence

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

Summary

Partial fix for #391 — three of the four reported problems:

  • Custom MCP source names get clobbered on refresh. refreshSource was preferring the MCP server's manifest name over the user's saved name (manifest.server?.name ?? existing?.name ?? namespace). Flipped to existing?.name ?? manifest.server?.name ?? namespace so user renames survive a refresh.
  • Editing a source name doesn't update the sidebar/home page until full reload. updateSource was writing to plugin storage but never updating the executor's in-memory source row. Added a ctx.core.sources.update({ id, scope, name, url }) call inside the same ctx.transaction as the storage write so both stay in sync atomically.
  • Long source names get truncated in the cloud sidebar with no way to read them. Added title={s.name} so the full name shows in a hover tooltip. (Resizable sidebar intentionally out of scope here.)

Still open from #391 (separate PR): secret label editing — there's no update handler in the secrets API today.

Test plan

  • bun run --cwd packages/plugins/mcp typecheck
  • bun run --cwd apps/cloud typecheck
  • bun run --cwd packages/plugins/mcp test — 46/46 pass
  • Manual: rename an MCP source, verify the sidebar updates without reload
  • Manual: refresh a renamed source, verify the custom name is preserved
  • Manual: hover a long source name in the sidebar, verify tooltip shows full name

- refreshSource: prefer existing saved name over MCP manifest name so
  user renames survive a refresh
- updateSource: re-register source via ctx.core.sources.update inside
  the same transaction as the storage write so the sidebar/home page
  reflect renames immediately instead of after a full reload
- cloud sidebar: title attribute on source name for hover tooltip

Partial fix for #391 (secret label editing still pending).
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 14c48cf Commit Preview URL

Branch Preview URL
May 04 2026, 08:10 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 14c48cf May 04 2026, 08:10 AM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 4, 2026

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@501

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@501

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@501

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@501

@executor-js/storage-core

npm i https://pkg.pr.new/@executor-js/storage-core@501

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@501

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@501

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@501

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@501

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@501

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@501

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@501

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@501

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@501

executor

npm i https://pkg.pr.new/executor@501

commit: 14c48cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant