Skip to content

[codex] Clean up MCP Effect error handling#536

Closed
RhysSullivan wants to merge 1 commit intocodex/effect-lint-baselinefrom
codex/effect-lint-mcp-cleanups
Closed

[codex] Clean up MCP Effect error handling#536
RhysSullivan wants to merge 1 commit intocodex/effect-lint-baselinefrom
codex/effect-lint-mcp-cleanups

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

Summary

  • preserve typed MCP connector/auth failures instead of laundering them through one local error
  • translate connection-access failures at the MCP HTTP boundary with stable user-facing messages
  • switch MCP edit save to promiseExit and replace manual Option tag checks with public helpers

Validation

  • bun run --cwd packages/plugins/mcp typecheck
  • bun run --cwd packages/plugins/mcp vitest run

Notes

  • Stacked on the baseline lint/skills PR so the new rules and skills are available while reviewing this diff.
  • Targeted lint for the edited files still reports the existing MCP extension inferred-type backlog; that is left for its own PR.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 5, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 6a6d205 Commit Preview URL

Branch Preview URL
May 05 2026, 11:08 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 5, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 6a6d205 May 05 2026, 11:08 PM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 5, 2026

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@536

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@536

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@536

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@536

@executor-js/storage-core

npm i https://pkg.pr.new/@executor-js/storage-core@536

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@536

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@536

executor

npm i https://pkg.pr.new/executor@536

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@536

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@536

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@536

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@536

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@536

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@536

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@536

commit: 6a6d205

@RhysSullivan
Copy link
Copy Markdown
Owner Author

Closing as superseded by newer focused MCP cleanup PRs, including #557, #560, #593, #650, #658, and #681.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant