Skip to content

[codex] Clean up Google Discovery Effect patterns#537

Closed
RhysSullivan wants to merge 1 commit intocodex/effect-lint-baselinefrom
codex/effect-lint-google-discovery
Closed

[codex] Clean up Google Discovery Effect patterns#537
RhysSullivan wants to merge 1 commit intocodex/effect-lint-baselinefrom
codex/effect-lint-google-discovery

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

Summary

  • use promiseExit for Google Discovery probe UI handling
  • remove try/catch and unknown error-message leakage from Google Discovery SDK paths
  • derive the extension type from the extension factory
  • preserve storage failures in the typed channel while translating only connection-owned secrets to source-facing errors

Validation

  • bun run typecheck in packages/plugins/google-discovery
  • bunx vitest run src/sdk/plugin.test.ts in packages/plugins/google-discovery
  • bunx oxlint -c .oxlintrc.jsonc packages/plugins/google-discovery/src/sdk/plugin.ts packages/plugins/google-discovery/src/react/AddGoogleDiscoverySource.tsx --deny-warnings

Notes

  • Stacked on the baseline lint/skills PR so these fixes are reviewed with the new rules available.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 5, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud af32c37 May 05 2026, 11:09 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 5, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing af32c37 Commit Preview URL

Branch Preview URL
May 05 2026, 11:09 PM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 5, 2026

Open in StackBlitz

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@537

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@537

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@537

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@537

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@537

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@537

@executor-js/storage-core

npm i https://pkg.pr.new/@executor-js/storage-core@537

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@537

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@537

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@537

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@537

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@537

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@537

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@537

executor

npm i https://pkg.pr.new/executor@537

commit: af32c37

@RhysSullivan
Copy link
Copy Markdown
Owner Author

Closing as superseded by newer audited cleanup PRs covering the same lint file set: #596, #643, #648, #657.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant