Skip to content

[codex] Clean up core OAuth service errors#544

Closed
RhysSullivan wants to merge 1 commit intocodex/effect-lint-baselinefrom
codex/effect-lint-core-oauth-service
Closed

[codex] Clean up core OAuth service errors#544
RhysSullivan wants to merge 1 commit intocodex/effect-lint-baselinefrom
codex/effect-lint-core-oauth-service

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

Summary

  • remove try/catch and native error-message plumbing from the OAuth service
  • use stable OAuth probe/start/complete/refresh messages at user-facing boundaries
  • yield tagged errors directly inside Effect.gen
  • keep detailed causes on refresh errors where the error type supports cause

Validation

  • bun run typecheck in packages/core/sdk
  • bunx vitest run src/oauth-discovery.test.ts src/oauth-helpers.test.ts src/connections.test.ts in packages/core/sdk
  • bunx oxlint -c .oxlintrc.jsonc packages/core/sdk/src/oauth-service.ts --deny-warnings

Stacked on #535.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing a06b31a Commit Preview URL

Branch Preview URL
May 06 2026, 02:11 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud a06b31a May 06 2026, 02:11 AM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2026

Open in StackBlitz

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@544

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@544

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@544

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@544

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@544

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@544

@executor-js/storage-core

npm i https://pkg.pr.new/@executor-js/storage-core@544

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@544

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@544

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@544

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@544

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@544

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@544

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@544

executor

npm i https://pkg.pr.new/executor@544

commit: a06b31a

@RhysSullivan RhysSullivan force-pushed the codex/effect-lint-core-oauth-service branch from 726744b to 93ffa32 Compare May 6, 2026 00:23
@RhysSullivan RhysSullivan force-pushed the codex/effect-lint-core-oauth-service branch from 93ffa32 to a06b31a Compare May 6, 2026 02:10
@RhysSullivan
Copy link
Copy Markdown
Owner Author

Closing as superseded by #655, which covers the same lint file set in the newer audited cleanup batch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant