Skip to content

Add OpenAPI parse boundary tests#686

Closed
RhysSullivan wants to merge 1 commit intocodex/batch16-openapi-plugin-boundariesfrom
codex/split-openapi-parse-tests-on-boundary
Closed

Add OpenAPI parse boundary tests#686
RhysSullivan wants to merge 1 commit intocodex/batch16-openapi-plugin-boundariesfrom
codex/split-openapi-parse-tests-on-boundary

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

Summary

  • split OpenAPI parse tests out of the older mixed parse cleanup PR
  • stack them on the OpenAPI parser boundary PR because the stable parse error messages depend on that implementation
  • assert error messages with toHaveProperty so the tests actually cover the Error message field

Verification

  • bunx oxlint --format=unix packages/plugins/openapi/src/sdk/parse.test.ts
  • bun run --cwd packages/plugins/openapi test -- src/sdk/parse.test.ts
  • bun run --cwd packages/plugins/openapi typecheck

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 8f91606 May 06 2026, 05:43 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 8f91606 Commit Preview URL

Branch Preview URL
May 06 2026, 05:42 AM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2026

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@686

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@686

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@686

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@686

@executor-js/storage-core

npm i https://pkg.pr.new/@executor-js/storage-core@686

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@686

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@686

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@686

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@686

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@686

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@686

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@686

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@686

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@686

executor

npm i https://pkg.pr.new/executor@686

commit: 8f91606

@RhysSullivan RhysSullivan marked this pull request as ready for review May 6, 2026 05:46
@RhysSullivan
Copy link
Copy Markdown
Owner Author

Closing as superseded by #535 and #687; the OpenAPI parse tests were included in the integrated Effect lint cleanup that is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant