fix: use truncate_str for UTF-8 safe string truncation#239
Open
slysian wants to merge 1 commit intoRightNow-AI:mainfrom
Open
fix: use truncate_str for UTF-8 safe string truncation#239slysian wants to merge 1 commit intoRightNow-AI:mainfrom
slysian wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
Replace all `&s[..s.len().min(N)]` patterns with `openfang_types::truncate_str(s, N)` to prevent panics when the byte index falls inside a multi-byte character (e.g. CJK / emoji). The bug manifests as a thread panic in session.rs when the thinking content contains non-ASCII text and the 200-byte boundary lands mid-character. Affected crates: openfang-memory, openfang-kernel, openfang-runtime. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
egargale
pushed a commit
to egargale/openfang
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all
&s[..s.len().min(N)]patterns withopenfang_types::truncate_str(s, N)to prevent panics when the byte index falls inside a multi-byte character (e.g. CJK / emoji).The bug manifests as a thread panic in session.rs when the thinking content contains non-ASCII text and the 200-byte boundary lands mid-character.
Affected crates: openfang-memory, openfang-kernel, openfang-runtime.