fix(kernel): fix embedding model config being hardcoded and ignored#275
Open
woodcoal wants to merge 1 commit intoRightNow-AI:mainfrom
Open
fix(kernel): fix embedding model config being hardcoded and ignored#275woodcoal wants to merge 1 commit intoRightNow-AI:mainfrom
woodcoal wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
Problem: - In kernel.rs, embedding driver creation hardcoded the model name - Config file setting memory.embedding_model was completely ignored - Always used "text-embedding-3-small" or "nomic-embed-text" instead of user config Solution: - Modified create_embedding_driver calls to use config.memory.embedding_model - Applied config model in all three auto-detection paths: 1. When embedding_provider is explicitly configured 2. When auto-detecting OpenAI 3. When auto-detecting Ollama - Added logging to show the actual model being used - Maintained backward compatibility: use defaults when config is empty Scope: - crates/openfang-kernel/src/kernel.rs: lines 757-803 Testing: 1. Set custom embedding_model in config file 2. Check logs after startup to verify model name 3. Verify vector search functionality works correctly
egargale
pushed a commit
to egargale/openfang
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Scope:
Testing: