Fix subscription content-filtering flakiness #1369
Merged
+143
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request fixes subscription content-filtering flakiness by addressing memory allocation bugs and improving error handling in the content filter operations.
Changes:
- Fixed memory allocation size calculation from
sizeof(char*)tosizeof(char)in CreateSubscription and SetContentFilter functions - Replaced macro-based error handling with explicit error checking and cleanup in SetContentFilter and ClearContentFilter
- Added proper resource finalization calls for content filter options
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes subscription content-filtering flakiness by addressing memory allocation bugs and improving error handling in the content filter operations.
Changes:
sizeof(char*)tosizeof(char)in CreateSubscription and SetContentFilter functionsFix: #1368