fix: cleanup OAuth event listeners and interval on login success#1126
Open
Anshumancanrock wants to merge 1 commit intoRocketChat:developfrom
Open
fix: cleanup OAuth event listeners and interval on login success#1126Anshumancanrock wants to merge 1 commit intoRocketChat:developfrom
Anshumancanrock wants to merge 1 commit intoRocketChat:developfrom
Conversation
|
|
Author
|
hi @Spiral-Memory , Could you please review this PR? Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: OAuth event listener and interval memory leak
Acceptance Criteria fulfillment
Fixes #1125
Description
This PR fixes a memory leak in the OAuth authentication flow where event listeners and interval timers persisted after login completion.
Before:
Event listeners and intervals weren't cleaned up on login success, causing memory leaks and hanging promises when popup was closed manually.
After:
Added cleanup() function with settled flag to immediately remove listeners/intervals on success or popup close, preventing race conditions and properly handling API errors.
PR Test Details
Testing OAuth flow: