Skip to content

chore: fix correct spelling of 'occurred' in error messages#38436

Open
laky241 wants to merge 9 commits intoRocketChat:developfrom
laky241:fix-typo-occurred-spelling
Open

chore: fix correct spelling of 'occurred' in error messages#38436
laky241 wants to merge 9 commits intoRocketChat:developfrom
laky241:fix-typo-occurred-spelling

Conversation

@laky241
Copy link

@laky241 laky241 commented Jan 30, 2026

Proposed changes (including videos or screenshots)

Found a spelling typo while exploring the codebase - "occured" should be "occurred" (double 'r'). Fixed it across 7 files in error messages, log statements, and code comments to keep everything consistent.

Files changed:

  • apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
  • ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts
  • ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts
  • packages/apps-engine/src/server/AppManager.ts
  • packages/apps-engine/src/server/errors/CompilerError.ts
  • packages/apps-engine/tests/server/errors/CompilerError.spec.ts
  • packages/media-signaling/src/lib/Call.ts

Issue(s)

No existing issue - found this while reading through the code.

Steps to test or reproduce

No testing needed - these are just string corrections. You can verify by:

Further comments

Small fix but helps maintain code quality. All instances of the typo have been updated for consistency.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected spelling errors in error messages and log outputs across multiple components to improve message clarity and consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@laky241 laky241 requested a review from a team as a code owner January 30, 2026 11:29
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 30, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 8.2.0, but it targets 8.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

⚠️ No Changeset found

Latest commit: 682e0df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2026

Walkthrough

This PR corrects a consistent spelling error across 7 files in the codebase, changing "occured" to "occurred" in error messages, log statements, comments, and test assertions. No functional or control-flow changes are introduced.

Changes

Cohort / File(s) Summary
SAML Authentication
apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
Corrected spelling in error HTML response message.
Media Calls SIP Providers
ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts, ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts
Fixed typo in error log messages for modify event handling.
Apps Engine Error Handling
packages/apps-engine/src/server/errors/CompilerError.ts
Corrected spelling in CompilerError message.
Apps Engine Comment & Test
packages/apps-engine/src/server/AppManager.ts, packages/apps-engine/tests/server/errors/CompilerError.spec.ts
Fixed comment spelling and updated expected test error message.
Media Signaling
packages/media-signaling/src/lib/Call.ts
Corrected spelling in WebRTC connection state change error log.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • KevLehman
  • lucas-a-pelegrino
  • tassoevan

Poem

🐰 A hop, a skip, a typo fixed,
"Occured" now "occurred"—our spelling's mixed!
Seven files now gleam so bright,
Every error message spells it right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The pull request title clearly and accurately summarizes the main change: fixing the spelling of 'occurred' in error messages across multiple files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

@sampaiodiego sampaiodiego changed the title fix: correct spelling of 'occurred' in error messages chore: fix correct spelling of 'occurred' in error messages Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.85%. Comparing base (7a10990) to head (3a69f90).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #38436   +/-   ##
========================================
  Coverage    70.85%   70.85%           
========================================
  Files         3161     3161           
  Lines       109785   109775   -10     
  Branches     19688    19704   +16     
========================================
+ Hits         77783    77784    +1     
+ Misses       29973    29963   -10     
+ Partials      2029     2028    -1     
Flag Coverage Δ
e2e 60.38% <ø> (+0.01%) ⬆️
e2e-api 47.86% <ø> (+0.08%) ⬆️
unit 72.05% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Feb 3, 2026
@aleksandernsilva aleksandernsilva added this to the 8.2.0 milestone Feb 3, 2026
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants