chore: fix correct spelling of 'occurred' in error messages#38436
chore: fix correct spelling of 'occurred' in error messages#38436laky241 wants to merge 9 commits intoRocketChat:developfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughThis PR corrects a consistent spelling error across 7 files in the codebase, changing "occured" to "occurred" in error messages, log statements, comments, and test assertions. No functional or control-flow changes are introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38436 +/- ##
========================================
Coverage 70.85% 70.85%
========================================
Files 3161 3161
Lines 109785 109775 -10
Branches 19688 19704 +16
========================================
+ Hits 77783 77784 +1
+ Misses 29973 29963 -10
+ Partials 2029 2028 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Found a spelling typo while exploring the codebase - "occured" should be "occurred" (double 'r'). Fixed it across 7 files in error messages, log statements, and code comments to keep everything consistent.
Files changed:
apps/meteor/app/meteor-accounts-saml/server/lib/SAML.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tsee/packages/media-calls/src/sip/providers/OutgoingSipCall.tspackages/apps-engine/src/server/AppManager.tspackages/apps-engine/src/server/errors/CompilerError.tspackages/apps-engine/tests/server/errors/CompilerError.spec.tspackages/media-signaling/src/lib/Call.tsIssue(s)
No existing issue - found this while reading through the code.
Steps to test or reproduce
No testing needed - these are just string corrections. You can verify by:
Further comments
Small fix but helps maintain code quality. All instances of the typo have been updated for consistency.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.