chore: delete `Sidebar` unused files by juliajforesti · Pull Request #38529 · RocketChat/Rocket.Chat

juliajforesti · 2026-02-06T17:32:51Z

CORE-1807

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Refactor
- Removed legacy sidebar component modules as part of internal code cleanup and infrastructure reorganization to improve maintainability and streamline the codebase.

dionisio-bot · 2026-02-06T17:32:55Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is targeting the wrong base branch. It should target 8.2.0, but it targets 8.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2026-02-06T17:32:56Z

⚠️ No Changeset found

Latest commit: 7509d7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-06T17:33:03Z

Caution

Review failed

The pull request is closed.

Walkthrough

This PR removes two unused React component files from the sidebar RoomList directory. SidebarItem.tsx and SidebarItemWithData.tsx previously rendered sidebar room items with avatars, menus, unread badges, and video conference actions across 204 total lines of code.

Changes

Cohort / File(s)	Summary
Deleted Sidebar Components `apps/meteor/client/sidebar/RoomList/SidebarItem.tsx`, `apps/meteor/client/sidebar/RoomList/SidebarItemWithData.tsx`	Removed two memoized React components and supporting types (RoomListRowProps, safeDateNotEqualCheck) that previously rendered sidebar room items with avatars, menus, unread badges, video conference actions, and route-switching logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Whoosh goes the code, away it flies,
No more sidebar items cloud the skies,
Two files gone, now lean and light,
The codebase bounces, clean and bright! ✨

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/sidebar-delete-unused

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39b14f6 and 7509d7b.

📒 Files selected for processing (2)

apps/meteor/client/sidebar/RoomList/SidebarItem.tsx
apps/meteor/client/sidebar/RoomList/SidebarItemWithData.tsx

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-02-06T17:45:45Z

📦 Docker Image Size Report

➡️ Changes

Service	Current	Baseline	Change
sum of all images	0B	0B	0B
account-service	0B	0B	0B
authorization-service	0B	0B	0B
ddp-streamer-service	0B	0B	0B
omnichannel-transcript-service	0B	0B	0B
presence-service	0B	0B	0B
queue-worker-service	0B	0B	0B
rocketchat	0B	0B	0B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "02/06 17:45 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.00]

Statistics (last 30 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.4GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 0B

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-38529
Baseline: develop
Timestamp: 2026-02-06 17:45:44 UTC
Historical data points: 30

Updated: Fri, 06 Feb 2026 17:45:44 GMT

codecov · 2026-02-06T17:56:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.40%. Comparing base (39b14f6) to head (7509d7b).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #38529   +/-   ##
========================================
  Coverage    70.39%   70.40%           
========================================
  Files         3161     3161           
  Lines       110656   110656           
  Branches     19868    19887   +19     
========================================
+ Hits         77896    77904    +8     
+ Misses       30734    30727    -7     
+ Partials      2026     2025    -1

Flag	Coverage Δ
e2e	`60.39% <ø> (+0.02%)`	⬆️
e2e-api	`48.84% <ø> (-0.03%)`	⬇️
unit	`71.35% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cubic-dev-ai

No issues found across 2 files

chore: delete unused files

7509d7b

dougfabris added this to the 8.2.0 milestone Feb 6, 2026

dougfabris approved these changes Feb 6, 2026

View reviewed changes

dougfabris marked this pull request as ready for review February 6, 2026 18:15

dougfabris requested a review from a team as a code owner February 6, 2026 18:15

dougfabris approved these changes Feb 6, 2026

View reviewed changes

dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Feb 6, 2026

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 6, 2026

kodiakhq bot merged commit 1a97371 into develop Feb 6, 2026
48 of 49 checks passed

kodiakhq bot deleted the chore/sidebar-delete-unused branch February 6, 2026 18:16

cubic-dev-ai bot reviewed Feb 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: delete `Sidebar` unused files#38529

chore: delete `Sidebar` unused files#38529
kodiakhq[bot] merged 1 commit intodevelopfrom
chore/sidebar-delete-unused

juliajforesti commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 6, 2026

Uh oh!

coderabbitai bot commented Feb 6, 2026 •

edited

Loading

Review failed

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

codecov bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

juliajforesti commented Feb 6, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 6, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

github-actions bot commented Feb 6, 2026

📦 Docker Image Size Report

➡️ Changes

📊 Historical Trend

Uh oh!

codecov bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

juliajforesti commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

dionisio-bot bot commented Feb 6, 2026 •

edited

Loading

coderabbitai bot commented Feb 6, 2026 •

edited

Loading

codecov bot commented Feb 6, 2026 •

edited

Loading