Skip to content

⚡ Bolt: Combine multiple aggregate queries in utility.py #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RohanExploit wants to merge 2 commits into
base: main
Choose a base branch
from
Open

⚡ Bolt: Combine multiple aggregate queries in utility.py #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
190edb0
Optimize /api/stats endpoint in utility.py by consolidating aggregate…
RohanExploit Mar 25, 2026
884632f
Fix Render deployment build command failure
RohanExploit Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,7 @@
## 2025-02-13 - API Route Prefix Consistency
**Learning:** Inconsistent application of `/api` prefixes between `main.py` router mounting and test suite request paths can lead to 404 errors during testing, even if the logic is correct. This is especially prevalent when multiple agents work on the same codebase with different assumptions about global prefixes.
**Action:** Always verify that `app.include_router` in `backend/main.py` uses `prefix="/api"` if the test suite (e.g., `tests/test_blockchain.py`) expects it. If a router is mounted without a prefix, ensure tests are updated or the prefix is added to `main.py` to maintain repository-wide consistency.

## 2025-03-25 - Combining Multiple Aggregate Queries with Group By
**Learning:** Executing a `count` or `sum` query for total stats, and then executing a separate `group_by` query for category breakdowns causes redundant table scans and multiple database round-trips.
**Action:** Consolidate aggregate calculations (like total counts and conditional sums) directly into the same query that groups by categories (e.g., `db.query(category, count, sum(case...)).group_by(category)`), then aggregate the final totals in Python. This reduces database workload and network latency significantly.
16 changes: 7 additions & 9 deletions backend/routers/utility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,18 @@ def get_stats(db: Session = Depends(get_db)):
if cached_stats:
return JSONResponse(content=cached_stats)

# Optimized: Single aggregate query to calculate total and resolved issues
stats = db.query(
# Optimized: Single aggregate query to calculate totals, resolved counts, and category distribution
cat_stats = db.query(
Comment on lines +56 to +57
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions verifying this change via test_stats_endpoint.py and says an isolated integration test was added, but there is no such test file under backend/tests/ in this PR. Either add the referenced test (recommended) or update the PR description/measurement instructions to point at an existing test path so reviewers can reproduce the claimed improvement.

Copilot uses AI. Check for mistakes.
Issue.category,
func.count(Issue.id).label("total"),
func.sum(case((Issue.status.in_(['resolved', 'verified']), 1), else_=0)).label("resolved")
).first()
).group_by(Issue.category).all()

total = stats.total or 0
resolved = int(stats.resolved or 0)
# Pending is everything else
total = sum(row.total for row in cat_stats) if cat_stats else 0
resolved = int(sum(row.resolved or 0 for row in cat_stats)) if cat_stats else 0
pending = total - resolved

# By category
cat_counts = db.query(Issue.category, func.count(Issue.id)).group_by(Issue.category).all()
issues_by_category = {cat: count for cat, count in cat_counts}
issues_by_category = {row.category: row.total for row in cat_stats}
Comment on lines +56 to +67
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactor changes how /stats computes totals/resolved/pending (now derived from grouped aggregates) but there is no automated test coverage for the /stats endpoint in backend/tests/ (other endpoints are covered via TestClient). Adding an integration test that seeds a few Issue rows with multiple categories/statuses and asserts total_issues, resolved_issues, pending_issues, and issues_by_category would help prevent regressions.

Copilot uses AI. Check for mistakes.

response = StatsResponse(
total_issues=total,
Expand Down
Loading
Loading