fix: Worker should only fetch async jobs#109
Open
carlosgjs wants to merge 1 commit intoRolnickLab:mainfrom
Open
fix: Worker should only fetch async jobs#109carlosgjs wants to merge 1 commit intoRolnickLab:mainfrom
carlosgjs wants to merge 1 commit intoRolnickLab:mainfrom
Conversation
📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new backend type for machine learning job execution and updates job fetching logic to only retrieve jobs intended for asynchronous processing.
Modified the
get_jobsfunction intrapdata/antenna/client.pyto filter jobs by thebackendparameter, ensuring only jobs meant for async processing are fetched (MLBackend.ASYNC_API).See corresponding antenna fix: RolnickLab/antenna#1118, it needs to be merged and deployed before this PR.
Tested against the above PR in antenna.
Summary by CodeRabbit