Open
Conversation
✅ Deploy Preview for antenna-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
annavik
commented
Oct 29, 2025
| import { useEffect, useState } from 'react' | ||
| import { GBIFTaxon } from './types' | ||
|
|
||
| const BASE_URL = 'https://api.gbif.org/v1/species' // See docs at https://techdocs.gbif.org/en/openapi/v1/species |
Member
Author
There was a problem hiding this comment.
More details about the GBIF API call in this file!
mihow
reviewed
Oct 30, 2025
Collaborator
There was a problem hiding this comment.
This is a awesome! The search works well.
- I like the rank filter. I'm not sure everyone will, but as long as it defaults to SPECIES I think it's an effective way to limit the search results and find what you are looking for.
- I think the Name field should be presented more as a search field, or at least say "Search" instead of "Select a value".
- I think it's important that we add parents automatically. That seems quite cumbersome for users. The GBIF API should return a parent ID. But we will likely need a backend function to connect the parent to existing parents in the Antenna DB.
- OR you could reverse the form fields a bit. Ask: "Where do you want to place the new taxa?" Then you search our existing taxa for the proper parent. Then we will know the rank of the parent, and we could even show existing children. Then when you search for a taxa, we already know the rank to filter on.
I'm guessing the global vs. project taxa filter was added to the ood branch but not in main.
I think we can allow users to add global taxa if they are from GBIF. But I know Yves and Chris will want to add custom taxa not in GBIF, which should be just for their project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
A small first step towards more flexible taxa management. Still more work and discussions to have related to this, but at least this will make it possible for users to add missing taxa that is present on GBIF. See notes below for some specific questions to discuss before merge.
List of Changes
Related Issues
Closes #975
Detailed Description
Notes
Screenshots and videos
Screen.Recording.2025-10-29.at.11.39.21.mov