fix: resolve relative symlinks in rules files using realpath of parent directory#11788
Open
p12tic wants to merge 1 commit intoRooCodeInc:mainfrom
Open
fix: resolve relative symlinks in rules files using realpath of parent directory#11788p12tic wants to merge 1 commit intoRooCodeInc:mainfrom
p12tic wants to merge 1 commit intoRooCodeInc:mainfrom
Conversation
…t directory When a .roo/rules directory is itself a symlink to an external directory, and files inside are relative symlinks (e.g., ../1-project.txt), the symlink targets were incorrectly resolved relative to the access path instead of the real filesystem path. Use fs.realpath() on the symlink's parent directory before resolving relative targets, matching how the OS resolves relative symlinks.
p12tic
requested review from
cte,
daniel-lxs,
hannesrudolph,
jr and
mrubens
as code owners
dosubot
bot
added
size:M
Collaborator
|
@roomote review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #11786
Description
When a .roo/rules directory is itself a symlink to an external directory, and files inside are relative symlinks (e.g., ../1-project.txt), the symlink targets were incorrectly resolved relative to the access path instead of the real filesystem path.
Use fs.realpath() on the symlink's parent directory before resolving relative targets, matching how the OS resolves relative symlinks.
Test Procedure
Reproduced the filesystem structure shown in the project, verified that issue exists by viewing "Modes -> Preview system prompt". The issue is reproducible before the bug fix and no longer is reproducible after the bug fix.
Pre-Submission Checklist
Screenshots / Videos
n/a
Documentation Updates
Not needed
Interactively review PR in Roo Code Cloud