Skip to content

Replace vulnerable ip package with native implementation #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannydulai merged 1 commit into from
Feb 3, 2026
Merged

Replace vulnerable ip package with native implementation #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"author": "Roon Labs, LLC",
"license": "Apache-2.0",
"dependencies": {
"ip": "^2.0.1",
"node-uuid": "^1.4.7",
"ws": ">=3.3.1"
}
Expand Down
9 changes: 7 additions & 2 deletions sood.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,15 @@ SOOD implements Roon Core discovery using UDP protocol
var util = require("util"),
events = require('events'),
dgram = require('dgram'),
IP = require('ip'),
uuid = require('node-uuid'),
os = require('os');

function getBroadcastAddress(ip, netmask) {
const ipParts = ip.split('.').map(Number);
const maskParts = netmask.split('.').map(Number);
return ipParts.map((octet, i) => octet | (~maskParts[i] & 255)).join('.');
}

var SOOD_PORT = 9003;
var SOOD_MULTICAST_IP = "239.255.90.90";

Expand Down Expand Up @@ -203,7 +208,7 @@ Sood.prototype._listen_iface = function(ip, netmask, ifacename) {
// this.logger.log(`SOOD: new sock: send ${ip}/${ifacename}`);
new_iface = true;
iface.send_sock = dgram.createSocket({ type: 'udp4' });
iface.broadcast = IP.subnet(ip, netmask).broadcastAddress;
iface.broadcast = getBroadcastAddress(ip, netmask);
iface.send_sock.on('error', (err) => {
// this.logger.log(`server error ${ip}`, err);
iface.send_sock.close();
Expand Down