-
Notifications
You must be signed in to change notification settings - Fork 559
Fix workflow tests that are failing #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a18f996
Address 'command' referenced before assignment error in tests
woodsh17 2d15730
Adjusting command format for design_macrocyclic_binder.sh and design_…
woodsh17 a45c3f9
Fail tests when example scripts exit non-zero
woodsh17 f43a81d
Changing number of designs for examples from 10 to 2 to speed up tests
woodsh17 778f8d4
Fix input_pdb path in design_macrocyclic_binder and fix incorrect cal…
woodsh17 a9b748b
Add print statement to list failed examples
woodsh17 5dff3eb
These changes split the examples up in chunks and runs the different …
woodsh17 e2378c7
Change num_designs in examples back to 10, since this is reset in tes…
woodsh17 6d0036b
Fix typo in main.yml in test_diffusion options
woodsh17 a629d43
Add step to cd into tests directory in main.yml
woodsh17 17f315b
Add index of chunk to test directory name
woodsh17 260692d
Edits to test_diffusion to make change setUp to setUpClass to make th…
woodsh17 a570b2b
Edit main.yml workflow so if an example fails, the test doesn't pass
woodsh17 4dd3a5f
Remove -o option from pipefail
woodsh17 56feb3b
Remove set pipefail
woodsh17 dc1867d
Edit main.yml so workflow runs
woodsh17 4d870c0
In setUpClass check that directory doesn't already exists, so tests d…
woodsh17 be5b7b6
Preseed DGL so avoid examples that are ran at the same time failing
woodsh17 681874e
Reduce length for design_tetrahedral_oligos to 600 to reduce run time
woodsh17 4aea4fd
Change design_nickel.sh num_designs back to 15
woodsh17 ead721f
Remove try block with except FileExistsError that isn't needed
woodsh17 dd7643d
Revert "Remove try block with except FileExistsError that isn't needed"
woodsh17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,15 @@ | ||
| #!/bin/bash | ||
|
|
||
| prefix=./outputs/uncond_cycpep | ||
| # Note that the indices in this pdb file have been | ||
| # shifted by +2 in chain A relative to pdbID 7zkr. | ||
| pdb='./input_pdbs/7zkr_GABARAP.pdb' | ||
| # Note that in the example below the indices in the | ||
| # input_pdbs/7zkr_GABARAP.pdb file have been shifted | ||
| # by +2 in chain A relative to pdbID 7zkr. | ||
|
|
||
| num_designs=10 | ||
| script="../scripts/run_inference.py" | ||
| $script --config-name base \ | ||
| inference.output_prefix=$prefix \ | ||
| inference.num_designs=$num_designs \ | ||
| ../scripts/run_inference.py \ | ||
| --config-name base \ | ||
| inference.output_prefix=example_outputs/uncond_cycpep \ | ||
| inference.num_designs=10 \ | ||
| 'contigmap.contigs=[12-18]' \ | ||
| inference.input_pdb=$pdb \ | ||
| inference.input_pdb=input_pdbs/7zkr_GABARAP.pdb \ | ||
| inference.cyclic=True \ | ||
| diffuser.T=50 \ | ||
| inference.cyc_chains='a' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I would personally would start to consider moving this logic into Python/shell script that live inside repository so it could be run/tested without the need to trigger the GH action. But for simple cases (like above) current approach is also works. 👍