Modernize copy prevention in utility/graph EdgeList/Node/Edge to use = delete#672
Open
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Open
Conversation
Replace old-style private-and-undefined copy constructor/assignment in Graph.hh (EdgeList, Node, Edge) and Digraph.hh (DirectedEdgeList, DirectedNode, DirectedEdge) with explicit = delete. Also corrects the copy assignment signatures from non-const T& to const T& to match the standard copy assignment operator form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace old-style private-and-undefined copy constructor/assignment with explicit
= deletein six internal classes acrossGraph.hhandDigraph.hh:Graph.hh:EdgeList,Node,EdgeDigraph.hh:DirectedEdgeList,DirectedNode,DirectedEdgeAlso corrects the copy assignment signatures from the non-standard
T&argument to the correctT const &form. TheGraphclass itself (which has a real, implemented copy constructor and assignment) is unchanged.Test plan
python3 ./scons.py -j16 mode=debugpasses