Modernize copy prevention in basic/ComparingTracer and MessageListenerFactory#673
Open
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Open
Conversation
…rFactory ComparingTracer: replace private-undefined copy ctor with public = delete; also explicitly delete copy assignment (std::fstream member makes copies impossible anyway, but = delete documents the intent clearly). MessageListenerFactory: remove redundant private-undefined copy ctor and assignment -- SingletonBase already deletes them via inheritance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related cleanups in
basic/:ComparingTracer.hh: Replace private-and-undefined copy constructor with public= delete; also explicitly delete copy assignment. Thestd::fstreammember already makes copies impossible, but= deletedocuments the intent at the class level.mpi/MessageListenerFactory.hh: Remove the redundant private-undefined copy constructor and copy assignment.MessageListenerFactoryinherits fromutility::SingletonBase<MessageListenerFactory>, which already deletes both copy operations — the manual declarations were dead code.Test plan
python3 ./scons.py -j16 mode=debugpasses