Apply Rule of Zero to disulfide energy neighbor iterators#689
Open
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Open
Apply Rule of Zero to disulfide energy neighbor iterators#689lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Conversation
The disulfide neighbor iterator classes in core/scoring/disulfides/ each had a user-declared destructor (defaulted in the .cc) and an old-style private undefined copy assignment. The destructor did nothing the compiler-generated virtual destructor wouldn't do, so remove both the declaration and the empty `= default` definition. Modernize the C++03-style copy-assignment prevention to public `= delete`. The intent is preserved: assignment must go through the polymorphic operator=(BaseType const &) override, which downcasts and copies all members; the implicit derived-derived operator= would bypass that path. A short comment captures this why. Touched: CentroidDisulfideNeighborIterator/ConstIterator, DisulfideMatchingNeighborIterator/ConstIterator, DisulfResNeighbIterator/ConstIterator.
roccomoretti
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResidueNeighborIterator/ResidueNeighborConstIteratordoes the same job.= deletefor the derived-typeoperator=. Behavior is unchanged: derived-derived assignment is still forbidden so all assignments flow through the polymorphicoperator=(BaseType const &)override that downcasts and copies all members.Touched:
CentroidDisulfideNeighborIterator/ConstIterator,DisulfideMatchingNeighborIterator/ConstIterator,DisulfResNeighbIterator/ConstIterator.Test plan
scons mode=release bin) passes with no errors