Apply Rule of Zero to BitSet and BitVector#690
Open
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Open
Apply Rule of Zero to BitSet and BitVector#690lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Conversation
Both class templates have a single value-type member (std::set / std::vector)
and no user-declared copy/move/assignment operators, so the explicit empty
destructors did nothing the compiler-generated ones wouldn't. They were also
suppressing the implicit move constructor and move assignment.
Remove the empty `~BitSet() {}` and `~BitVector() {}` declarations so the
classes follow the Rule of Zero and gain implicit move support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utility::BitSet<B>andutility::BitVector<B>each had only a single value-type member (std::set<B>andstd::vector<bool>respectively), no user-declared copy/move/assignment operators, and an explicit empty destructor.~BitSet() {}/~BitVector() {}did nothing the compiler-generated destructor wouldn't have done, and they suppressed the implicit move constructor and move assignment.Test plan
python3 ./scons.py -j16 mode=release binbuilds cleanly.