fix: reduce CodeQL noise from tests and harden scan findings#269
fix: reduce CodeQL noise from tests and harden scan findings#269RtlZeroMemory merged 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis pull request establishes CodeQL analysis configuration by introducing a new configuration file that excludes test-related paths, updates the CodeQL workflow to use this configuration, clarifies documentation about test filtering behavior, refactors numeric formatting logic into a helper function, adds test coverage for exponent formatting, and modifies the test script to perform literal substring matching for the --filter flag. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
Summary
scripts/run-tests.mjs --filterto use literal substring matching instead of raw regex inputValidation
npm run lintnpm run typechecknpm run buildnode scripts/run-tests.mjs --scope packages --filter "compositionWidgets"node scripts/run-tests.mjs --scope scripts --filter "check-core-portability"Notes
mainwere concentrated in test paths, but there were also two non-test alerts inscripts/run-tests.mjsandpackages/core/src/constraints/helpers.ts; this PR addresses both.Summary by CodeRabbit
Documentation
--filterflag behavior to match literal substrings in test file paths rather than regex patternsTests