Fix collapsed group spacing for empty groups#495
Merged
jeffscottward merged 8 commits intoRunMaestro:mainfrom Mar 25, 2026
Merged
Fix collapsed group spacing for empty groups#495jeffscottward merged 8 commits intoRunMaestro:mainfrom
jeffscottward merged 8 commits intoRunMaestro:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdates SessionList rendering so collapsed groups show compact session "pills" and collapsed groups with no child sessions render no collapsed container; adds a test for that behavior and reformats release notes in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes a UI spacing bug where collapsing a group that contains no top-level agents (i.e., Changes made:
The fix is minimal, targeted, and logically correct. No side effects are introduced for the expanded-group path or for groups that do have top-level sessions. Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Render Group] --> B{group.collapsed?}
B -- No --> C[Render expanded session list\nwith border-l]
B -- Yes --> D{groupCollapsedPills\n.length > 0?}
D -- Yes --> E[Render collapsed pill container\nml-8 mr-3 mt-1 mb-2]
D -- No --> F[Render null\nno spacing / no container]
Last reviewed commit: 5002a82 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Collaborator
|
This looks safe, but on the fact chance that it causes some regression or is going to hold off on 0.15.0 ... first merge after i publish that version. |
jeffscottward
pushed a commit
to jeffscottward/Maestro
that referenced
this pull request
Mar 3, 2026
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@prompt.XXXXXX.txt`:
- Around line 1-17: Delete the generated artifact file "prompt.XXXXXX.txt" from
the branch (remove it from the PR changes) so it is no longer tracked or part of
the commit set; locate the file by name in the diff/commit and remove it (git rm
/ delete and commit/push) and ensure it is not reintroduced (optionally add the
filename pattern to .gitignore) so lint/format and tests no longer fail due to
this non-product file.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
payload.XXXXXX.jsonprompt.XXXXXX.txt
✅ Files skipped from review due to trivial changes (1)
- payload.XXXXXX.json
jeffscottward
pushed a commit
to jeffscottward/Maestro
that referenced
this pull request
Mar 3, 2026
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/releases.md`:
- Line 35: Fix typos and grammar in the release notes by replacing the incorrect
tokens: change "FIle" to "File" in the sentence that begins "🗄️ Document
Graphs. Launch from file preview...", change "built in" to "built-in", change
"You will received" to "You will receive", and change "Github" to "GitHub" so
the release notes read with correct spelling and hyphenation.
- Line 41: Update the subsection headings in the releases document to use
consistent third-level headings (###) under each release's second-level heading
(## vX.Y.x) and fix the typo in the release title "Smaller Changes in 014.x" to
"Smaller Changes in 0.14.x"; specifically replace any stray top-level (#) or
second-level (##) headings within release sections (e.g., the "Smaller Changes
in 014.x" heading and the other subsections currently using `#/`##) with ### so
the document hierarchy and generated TOC remain correct.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/releases.mdpayload.XXXXXX.jsonsrc/renderer/components/FilePreview.tsxsrc/renderer/hooks/batch/useBatchProcessor.ts
✅ Files skipped from review due to trivial changes (1)
- src/renderer/hooks/batch/useBatchProcessor.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- payload.XXXXXX.json
Collaborator
|
@jeffscottward would you address the conflicts? ready to merge this in. |
Contributor
Author
|
@reachraza these are the exact files i was choking on before can you take a look at what is supposed to be correct? |
jeffscottward
force-pushed
the
group-css-fix
branch
from
d0637e0 to
1a1daf8
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/releases.md`:
- Line 22: Replace the three compound modifiers that should be hyphenated:
change the phrase "open source" to "open-source", change "cross context" to
"cross-context", and change "built in" to "built-in" in docs/releases.md so the
compound adjectives preceding nouns are properly hyphenated; search for these
exact phrases to locate and update them.
- Line 201: Update the capitalization of the brand name in the release note:
change the phrase "Github Worktree support was added." (the line that begins
"Github Worktree support") to "GitHub Worktree support was added." so that
"GitHub" uses the correct capital "H" in the releases.md text.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #494
Summary by CodeRabbit
Bug Fixes
Tests
Documentation