Skip to content

Conversation

@tarcieri
Copy link
Member

Or rather, this imports crypto-common as common using the package = crypto-common syntax in Cargo.toml, then re-exports it, which should hopefully make for better diagnostics.

This is shorter and more convenient for imports.

Where crates were previously exporting crypto_common, this adds an alias with a deprecation. Adding such an alias to digest was necessary to even get anything to compile.

Or rather, this imports `crypto-common` as `common` using the
`package = crypto-common` syntax in Cargo.toml, then re-exports it,
which should hopefully make for better diagnostics.

This is shorter and more convenient for imports.

Where crates were previously exporting `crypto_common`, this adds an
alias with a deprecation. Adding such an alias to `digest` was necessary
to even get anything to compile.
@tarcieri tarcieri force-pushed the re-export-crypto_common-as-common branch from 6c52097 to 1f077f4 Compare January 25, 2026 01:34
@tarcieri tarcieri changed the title [WIP] Re-export crypto_common as common Re-export crypto_common as common Jan 25, 2026
@tarcieri tarcieri marked this pull request as ready for review January 25, 2026 01:34
@tarcieri tarcieri requested a review from newpavlov January 25, 2026 01:34
Comment on lines +9 to +10
### Added
- Re-export `crypto_common` as `common` ([#2237])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: aead didn't previously re-export crypto-common itself, only select things from it

@tarcieri tarcieri merged commit e101c8d into master Jan 25, 2026
46 checks passed
@tarcieri tarcieri deleted the re-export-crypto_common-as-common branch January 25, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants