fix: resolve container decoration and button layout crashes#12
Closed
fix: resolve container decoration and button layout crashes#12
Conversation
- Wrap buildServerTextButton with Semantics(button: true, label: ...) - Wrap buildServerOutlinedButton with Semantics(button: true, label: ...) Made-with: Cursor
- Wrap buildServerInkWell with Semantics(button: node.action != null) - Wrap buildServerGestureDetector with Semantics for accessibility Made-with: Cursor
- Wrap selectableText with Semantics(label: content) - Wrap richText with Semantics using concatenated span text Made-with: Cursor
- Wrap placeholder with Semantics(label: 'Placeholder') - Wrap circleAvatar with Semantics(label: label, image: imageUrl != null) Made-with: Cursor
- Replace snackbar placeholder with actual URL launching - Use launchUrl with LaunchMode.externalApplication Made-with: Cursor
- Add url_launcher ^6.3.2 to pubspec.yaml Made-with: Cursor
- Cover parsePadding, parseAlignment, parseAxis, parseTextAlign - Cover parseFontWeight, parseFontStyle, parseTextDecoration - Cover parseBoxFit, parseBorderRadius, parseBoxConstraints - Cover parseDuration, parseCurve, parseScrollPhysics Made-with: Cursor
- Test center, align, padding, sizedBox, opacity, clipRRect - Test safeArea, rotatedBox, ignorePointer, offstage Made-with: Cursor
- Test textButton, outlinedButton, iconButton, FAB rendering - Verify Semantics wrappers and label display Made-with: Cursor
- Test listTile, expansionTile, switchListTile, checkboxListTile - Verify toggle callbacks report correct id and value Made-with: Cursor
- Test selectableText, richText rendering and Semantics Made-with: Cursor
- Test slider rendering and value clamping - Test radio widget rendering Made-with: Cursor
- Test placeholder, circleAvatar, verticalDivider - Verify Semantics wrappers on placeholder and avatar Made-with: Cursor
- Test inkWell, gestureDetector, tooltip, dismissible - Verify Semantics and action dispatch on tap Made-with: Cursor
- Test scrollView, gridView, pageView rendering Made-with: Cursor
- Test material, hero, indexedStack, transform, banner Made-with: Cursor
- Test animatedContainer, animatedOpacity, animatedCrossFade - Test animatedSwitcher and animatedSize rendering Made-with: Cursor
- Test table with rows and dataTable with columns and rows Made-with: Cursor
- Full listing of all 103 component types with props and children support - Organized by category: layout, wrappers, decorators, scrollables, etc. - Include action types reference table Made-with: Cursor
- Add new component categories: wrappers, decorators, scrollables, animated - Update openUrl action description to reflect url_launcher integration - Expand accessibility section with new Semantics-wrapped components Made-with: Cursor
- Expand component table from 22 to 103 types across 13 categories - Add advanced_components to demo screens table - Add link to COMPONENTS.md reference catalog Made-with: Cursor
- Showcase layout wrappers, decorators, tiles, button variants - Demo opacity levels, transforms, rich text, and circle avatars Made-with: Cursor
- Add Advanced Components button between New Components and Expressions Demo Made-with: Cursor
- Parse 'decoration' prop with gradient, border, borderRadius and boxShadow - Support width and height props on containers - Add GestureDetector wrapping for containers with actions - Import parsing_utils for BoxDecoration parsing Made-with: Cursor
- Remove SizedBox(width: double.infinity) that crashed inside Row widgets - Use natural button sizing with symmetric padding instead - Buttons still stretch to full width via Column crossAxisAlignment.stretch Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_buildContainerto parse thedecorationprop (gradient, borderRadius, color, border, boxShadow) instead of only readingbackgroundColorSizedBox(width: double.infinity)frombuildServerButtonthat caused infinite-width crashes when buttons were placed insideRowwidgetswidth,height, and tapactionon container componentsTest plan
flutter analyzereports zero errors