Simplify offset and address calculation#3
Open
yongwonshin wants to merge 1 commit intoSAITPublic:developfrom
Open
Simplify offset and address calculation#3yongwonshin wants to merge 1 commit intoSAITPublic:developfrom
yongwonshin wants to merge 1 commit intoSAITPublic:developfrom
Conversation
- addr_gen_s accepts any size of offset and col - flatten and inline address calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
w_idx,gidx,offset) are to help address mapping, which unnecessarily complicates the code.Key changes
addr_gen_sutility function which accepts any offset and column value.Test
OpenCLPimIntegrationTests.To Reviewers
addr_gen_scallsaddr_gen_which adds slight overhead.