[PULL REQUEST] Sort needed before integerize_1d function#103
Open
GregorSchroeder wants to merge 2 commits intomainfrom
Open
[PULL REQUEST] Sort needed before integerize_1d function#103GregorSchroeder wants to merge 2 commits intomainfrom
GregorSchroeder wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit sorting before calling integerize_1d to make the weighted-random integerization deterministic and consistent across runs.
Changes:
- Sort intermediate demographic frames by
race,sex,agebefore integerization in annual cycle calculations. - Sort
pop_dfbefore integerizing population in the main pipeline. - Minor formatting adjustments around
round(...)calls.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| python/annual_cycle.py | Adds sort_values(["race","sex","age"]) ahead of integerization in births/deaths/migration/newborns flows. |
| main.py | Sorts pop_df in-place before integerize_population to stabilize row order. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this pull request. What changes are being made?
The
integerize_1dfunction implemented in #98 with the "weighted_random" methodology requires the data to be explicitly sorted to avoid any issues with stochastic variation from run to run. This pull request adds explicit sorts before usage.What issues does this pull request address?
closes #102