Update Pandora track and shower discrimination scheme and training#840
Update Pandora track and shower discrimination scheme and training#840
Conversation
SFBayLaser
left a comment
There was a problem hiding this comment.
Given the changes in pandora the updates here seem to be fine.
Please ping me about necessary updates to icarus_data, can try to do asap
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build larsoft@v10_20_04 LArSoft/lar*@LARSOFT_SUITE_v10_20_04 SBNSoftware/sbnalg@v10_20_04 SBNSoftware/sbnobj@v10_20_04 SBNSoftware/sbnanaobj@v10_20_04 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbncode@v10_20_04 SBNSoftware/icarusutil@v10_15_00 SBNSoftware/icaruscode@v10_20_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
This PR changes the Pandora XML (particularly, the
LArBdtPfoCharacterisationalgorithm) to accomodate for changes to the track/shower discrimination scheme, and to introduce the corresponding new BDT training files.Context
The code change within Pandora consists in choosing the Collection plane to compute calorimetric variables used in the track/shower discrimination BDT, instead of relying on the Induction-1 plane. Due to mapping technicalities, the Pandora
Wview (commonly mapped to Collection in other LArTPCs) is mapped to Induction-1 in ICARUS, whereas theUandVviews are mapped to Induction-2 or Collection, based on the TPC. For more details on the Pandora code change, check the corresponding PandoraPFA/LArContent PR #246, SBN DocDB 40882, and SBN DocDB 40375.The
UseICARUSCollectionPlanealgorithm parameter controls the plane used to determine whether charge information is available or not for the reconstructed particle (Collection iftrue), and as a result which BDT to use.Two ICARUS-specific tools are defined:
ConeChargeFeatureTool_ICARUS, andThreeDChargeFeatureTool_ICARUS. TheUseICARUSCollectionPlanetool parameter controls the plane used for computing charge-based variables (Collection iftrue).This modification was agreed with Pandora experts.
BDT re-training
Information on the BDT re-training are available on SBN DocDB 42432.
The track/shower BDT was re-trained with BNB MC samples based on
icaruscodev09_84_00_01, balanced between track and shower particles, and with "good reconstruction" cuts. The accuracy of the classification is shown to improve substantially across all particle types.Dependency
This PR needs the LArSoft/
larpandoracontentv04_16_00 release (LArSoft/larpandoracontent PR #78), i.e.,larsoftv10_08_02.It also needs the corresponding BDT XMLs added to
icarus_data: a newicarus_datarelease will be needed to pick up the right XMLs.After this PR is merged, the CAFMaker needs to be updated to pick up the newly-named tools. A companion PR in
sbncodewas opened (sbncode PR #546).Review
Tagging for review:
Also tagging @acampani as assignee.
Thanks!